Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @nimrod-starkware)

crates/committer/src/patricia_merkle_tree/types.rs line 41 at r1 (raw file):

    ) -> NodeIndex {
        let PathToBottom { path, length } = path_to_bottom;
        (index << length.0) + NodeIndex(U256::from_be_bytes(path.0.to_bytes_be()))

see below

Suggestion:

Self::from_felt_value(path.0)

crates/committer/src/patricia_merkle_tree/types.rs line 68 at r1 (raw file):

    }

    fn from_felt(felt: &Felt, tree_height: &TreeHeight) -> Self {

maybe better rename, to be crystal clear..
then, add a from_felt_value function (private!) for the NodeIndex(U256::from_be_bytes(felt.to_bytes_be())) logic

Suggestion:

from_leaf_felt

crates/committer/src/patricia_merkle_tree/types.rs line 69 at r1 (raw file):

    fn from_felt(felt: &Felt, tree_height: &TreeHeight) -> Self {
        Self(U256::from(1_u8) << tree_height.0) + NodeIndex(U256::from_be_bytes(felt.to_bytes_be()))

see above

Suggestion:

Self::from_felt_value(felt)

Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @dorimedini-starkware)

crates/committer/src/patricia_merkle_tree/types.rs line 41 at r1 (raw file):

Done.

crates/committer/src/patricia_merkle_tree/types.rs line 68 at r1 (raw file):

Done.

crates/committer/src/patricia_merkle_tree/types.rs line 69 at r1 (raw file):

Done.

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @nimrod-starkware)